De-duplicate passwords imports #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
aataraxiaa
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Looks great so far @graeme. Thanks for the clear naming on the test credentials, super helpful 🙂. Left minor comment formatting suggestion. I can review new commits when they are ready.
| @@ -41,3 +41,12 @@ extension Optional: OptionalProtocol { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| extension Optional where Wrapped == String { | |||
| var isNilOrEmpty: Bool { | |||
DuckDuckGo/DataImport/Logins/SecureVault/SecureVaultLoginImporter.swift
Outdated
Show resolved
Hide resolved
graeme
force-pushed
the
graeme/deduplicate-passwords
branch
from
314cb1b
to
3e00442
Compare
14 tasks
aataraxiaa
approved these changes
Jul 5, 2024
| @@ -186,7 +198,11 @@ final class MockSecureVault<T: AutofillDatabaseProvider>: AutofillSecureVault { | |||
| return nil | |||
| } | |||
|
|
|||
| func inDatabaseTransaction(_ block: @escaping (Database) throws -> Void) throws {} | |||
| var spyInDatabaseTransactionBlock: ((Database) throws -> Void)? | |||
aataraxiaa
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202926619870900/1207598052765981/f
Tech Design URL: https://app.asana.com/0/1202926619870900/1207676132777813/f
Description:
Duplicated passwords are a frequently-reported challenge in adopting our password manager.
Users who import twice or from two different sources may find themselves with hundreds of duplicated entries, making their UI a mess.
This change means that, upon import, passwords that are already stored are not duplicated.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation
Download latest build from Builds: Deduplicate passwords on import
Reset your autofill data (Debug → Reset Data → Reset Autofill Data)
Import login_deduplication_starting_data.csv from ✓ CSV files with test cases: 0.5 days
Check your logins to ensure that all 17 entries have been imported
Import login_deduplication_test_data.csv from ✓ CSV files with test cases: 0.5 days
Check against ✓ Define a duplicate: 0.5 days rules to make sure duplicates have been removed (the title/notes values should help you identify each case against the examples defined in the rules).
Import login_import_data_large.csv from ✓ CSV files with test cases: 0.5 days to test large import data sets
Import the data from the previous step again to test large import data + large stored data sets
This could be better and I'm timeboxing some low-hanging fruit optimisations to see if can be improved while trying to avoid DB schema changes that may require a migration
The autofill UI is currently not handling large volumes of data very well even before this project. This is being discussed and tracked in Logins/Autofill: improve list view performance